fixed review comments

PeerDB-io · Oct 18, 2023 · 4142a73 · 4142a73
1 parent 2cdad8b
commit 4142a73
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/dev-peerdb.sh b/dev-peerdb.sh
@@ -7,4 +7,4 @@ then
     exit 1
 fi
 
-docker compose -f docker-compose-dev.yml up --build
+docker compose -f docker-compose-dev.yml up --build
diff --git a/docker-compose-dev.yml b/docker-compose-dev.yml
@@ -18,7 +18,7 @@ x-flow-worker-env: &flow-worker-env
   AWS_REGION: ${AWS_REGION:-}
   # For GCS, set this as: https://storage.googleapis.com
   AWS_ENDPOINT: ${AWS_ENDPOINT:-}
-  # enables worker profiling using Go's pprof
+  # enables worker profiling using Grafana Pyroscope
   ENABLE_PROFILING: "true"
   # enables exporting of mirror metrics to Prometheus for visualization using Grafana
   ENABLE_METRICS: "true"

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -18,11 +18,8 @@ x-flow-worker-env: &flow-worker-env
   AWS_REGION: ${AWS_REGION:-}
   # For GCS, set this as: https://storage.googleapis.com
   AWS_ENDPOINT: ${AWS_ENDPOINT:-}
-  # enables worker profiling using Go's pprof
-  ENABLE_PROFILING: "true"
   # enables exporting of mirror metrics to Prometheus for visualization using Grafana
   ENABLE_METRICS: "true"
-  PYROSCOPE_SERVER_ADDRESS: http://pyroscope:4040
 
 services:
   catalog:
@@ -65,12 +62,6 @@ services:
     labels:
       kompose.volume.type: configMap
 
-  pyroscope:
-    container_name: pyroscope
-    image: grafana/pyroscope:latest
-    ports:
-      - 4040:4040
-
   temporal-admin-tools:
     container_name: temporal-admin-tools
     depends_on:
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,4 +7,4 @@ then @@
         exit 1
     fi
-    docker compose -f docker-compose-dev.yml up --build
+    docker compose -f docker-compose-dev.yml up --build