query once

PeerDB-io · Jan 11, 2024 · 6210779 · 6210779
1 parent f942619
commit 6210779
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/flow/shared/alerting/alerting.go b/flow/shared/alerting/alerting.go
@@ -63,7 +63,8 @@ func NewAlerter(catalogPool *pgxpool.Pool) (*Alerter, error) {
 // Only raises an alert if another alert with the same key hasn't been raised
 // in the past X minutes, where X is configurable and defaults to 15 minutes
 func (a *Alerter) AlertIf(ctx context.Context, alertKey string, alertMessage string) {
-	if dynamicconf.PeerDBAlertingGapMinutesAsDuration(ctx) == 0 {
+	dur := dynamicconf.PeerDBAlertingGapMinutesAsDuration(ctx)
+	if dur == 0 {
 		a.logger.WarnContext(ctx, "Alerting disabled via environment variable, returning")
 		return
 	}
@@ -80,7 +81,7 @@ func (a *Alerter) AlertIf(ctx context.Context, alertKey string, alertMessage str
 		return
 	}
 
-	if time.Since(createdTimestamp) >= dynamicconf.PeerDBAlertingGapMinutesAsDuration(ctx) {
+	if time.Since(createdTimestamp) >= dur {
 		a.AddAlertToCatalog(ctx, alertKey, alertMessage)
 		a.AlertToSlack(ctx, alertKey, alertMessage)
 	}