Telemetry for peer: only televise non nil validate peer err (#1653)

Log non flow error only if not nil for validate peer
PeerDB-io · Apr 30, 2024 · 7866e79 · 7866e79
1 parent e3f6ef6
commit 7866e79
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/flow/cmd/validate_peer.go b/flow/cmd/validate_peer.go
@@ -61,11 +61,11 @@ func (h *FlowRequestHandler) ValidatePeer(
 	validationConn, ok := conn.(connectors.ValidationConnector)
 	if ok {
 		validErr := validationConn.ValidateCheck(ctx)
-		displayErr := fmt.Sprintf("failed to validate peer %s: %v", req.Peer.Name, validErr)
-		h.alerter.LogNonFlowWarning(ctx, telemetry.CreatePeer, req.Peer.Name,
-			displayErr,
-		)
 		if validErr != nil {
+			displayErr := fmt.Sprintf("failed to validate peer %s: %v", req.Peer.Name, validErr)
+			h.alerter.LogNonFlowWarning(ctx, telemetry.CreatePeer, req.Peer.Name,
+				displayErr,
+			)
 			return &protos.ValidatePeerResponse{
 				Status:  protos.ValidatePeerStatus_INVALID,
 				Message: displayErr,