Skip to content

Commit

Permalink
more fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
iskakaushik committed Oct 20, 2023
1 parent 0edb5a5 commit 78e6ad5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ui/app/mirrors/create/helpers/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const blankQRepSetting: QRepConfig = {
batchSizeInt: 0,
batchDurationSeconds: 0,
maxParallelWorkers: 8,
waitBetweenBatchesSeconds: 0,
waitBetweenBatchesSeconds: 30,
writeMode: undefined,
stagingPath: '',
numRowsPerPartition: 0,
Expand Down
2 changes: 1 addition & 1 deletion ui/app/mirrors/create/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,6 @@ export const qrepSchema = z.object({
invalid_type_error: 'Batch wait must be a number',
})
.int()
.min(0, 'Batch wait must be a non-negative integer')
.min(1, 'Batch wait must be a non-negative integer')
.optional(),
});
8 changes: 7 additions & 1 deletion ui/app/mirrors/status/qrep/[mirrorId]/qrepConfigViewer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import prisma from '@/app/utils/prisma';
import { QRepConfig } from '@/grpc_generated/flow';
import { Badge } from '@/lib/Badge';
import { Icon } from '@/lib/Icon';
import { ProgressCircle } from '@/lib/ProgressCircle';

export const dynamic = 'force-dynamic';

Expand All @@ -25,7 +26,12 @@ export default async function QRepConfigViewer({
});

if (!configBuffer?.config_proto) {
return <div>Config Unavailable</div>;
return (
<div>
<ProgressCircle variant='determinate_progress_circle' />
Waiting for mirror to start...
</div>
);
}

let qrepConfig = QRepConfig.decode(configBuffer.config_proto);
Expand Down

0 comments on commit 78e6ad5

Please sign in to comment.