Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
Amogh-Bharadwaj committed Jan 20, 2025
1 parent 735ae63 commit 80d31a7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 9 deletions.
2 changes: 1 addition & 1 deletion flow/connectors/clickhouse/clickhouse.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ type ClickHouseConnector struct {

type ClickHouseDestinationCheckInput struct {

Check failure on line 39 in flow/connectors/clickhouse/clickhouse.go

View workflow job for this annotation

GitHub Actions / lint

fieldalignment: struct with 40 pointer bytes could be 32 (govet)
TableMappings []*protos.TableMapping
TableNameSchemaMapping map[string]*protos.TableSchema
SyncedAtColName string
Resync bool
DoInitialSnapshot bool
TableNameSchemaMapping map[string]*protos.TableSchema
}

func ValidateS3(ctx context.Context, creds *utils.ClickHouseS3Credentials) error {
Expand Down
22 changes: 14 additions & 8 deletions ui/app/mirrors/[mirrorId]/edit/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -121,16 +121,22 @@ const EditMirror = ({ params: { mirrorId } }: EditMirrorProps) => {
addedTables: additionalTables,
};

const res = await fetch('/api/v1/mirrors/cdc/edit/validate', {
method: 'POST',
body: JSON.stringify(validateReq),
cache: 'no-store',
});
try {
const res = await fetch('/api/v1/mirrors/cdc/edit/validate', {
method: 'POST',
body: JSON.stringify(validateReq),
cache: 'no-store',
});

if (!res.ok) {
notifyErr(`Table addition invalidated: ${res.statusText}`);
if (!res.ok) {
const errRes = await res.json();
notifyErr('Table addition invalidated: ' + errRes.message);
setLoading(false);
return;
}
} catch (e) {
console.error(e);
setLoading(false);
return;
}
}
const req: FlowStateChangeRequest = {
Expand Down

0 comments on commit 80d31a7

Please sign in to comment.