Remove query box, truncate step (#1446)

PeerDB-io · Mar 13, 2024 · 870d2b5 · 870d2b5
1 parent 1c6f78a
commit 870d2b5
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 29 deletions.
diff --git a/flow/connectors/postgres/qrep.go b/flow/connectors/postgres/qrep.go
@@ -489,7 +489,8 @@ func (c *PostgresConnector) SetupQRepMetadataTables(ctx context.Context, config
 	c.logger.Info("Setup metadata table.")
 
 	if config.WriteMode != nil &&
-		config.WriteMode.WriteType == protos.QRepWriteType_QREP_WRITE_MODE_OVERWRITE {
+		config.WriteMode.WriteType == protos.QRepWriteType_QREP_WRITE_MODE_OVERWRITE &&
+		config.SourcePeer.Type != protos.DBType_SNOWFLAKE {
 		_, err = c.conn.Exec(ctx,
 			"TRUNCATE TABLE "+config.DestinationTableIdentifier)
 		if err != nil {

diff --git a/ui/app/mirrors/create/handlers.ts b/ui/app/mirrors/create/handlers.ts
@@ -206,6 +206,7 @@ export const handleCreateQRep = async (
   }
 
   if (config.sourcePeer?.snowflakeConfig) {
+    config.query = 'SELECT * FROM ' + config.watermarkTable;
     if (config.watermarkTable == '') {
       notify('Please fill in the source table');
       return;

diff --git a/ui/app/mirrors/create/helpers/common.ts b/ui/app/mirrors/create/helpers/common.ts
@@ -72,6 +72,6 @@ export const blankSnowflakeQRepSetting = {
   } as QRepWriteMode,
   stagingPath: '',
   numRowsPerPartition: 100000,
-  setupWatermarkTableOnDestination: false,
+  setupWatermarkTableOnDestination: true,
   initialCopyOnly: true,
 };
diff --git a/ui/app/mirrors/create/helpers/qrep.ts b/ui/app/mirrors/create/helpers/qrep.ts
@@ -32,7 +32,7 @@ export const qrepSettings: MirrorSetting[] = [
     stateHandler: (value, setter) =>
       setter((curr: QRepConfig) => ({
         ...curr,
-        setupWatermarkTableOnDestination: (value as boolean) || false,
+        setupWatermarkTableOnDestination: (value as boolean) || true,
       })),
     tips: 'Specify if you want to create the watermark table on the destination as-is, can be used for some queries.',
     type: 'switch',

diff --git a/ui/app/mirrors/create/page.tsx b/ui/app/mirrors/create/page.tsx
@@ -82,17 +82,6 @@ export default function CreateMirrors() {
       .then((res) => {
         setPeers(res);
       });
-
-    if (mirrorType === 'Query Replication' || mirrorType === 'XMIN') {
-      if (mirrorType === 'XMIN') {
-        setConfig((curr) => {
-          return { ...curr, setupWatermarkTableOnDestination: true };
-        });
-      } else
-        setConfig((curr) => {
-          return { ...curr, setupWatermarkTableOnDestination: false };
-        });
-    }
   }, [mirrorType]);
 
   let listMirrorsPage = () => {

diff --git a/ui/app/mirrors/create/qrep/snowflakeQrep.tsx b/ui/app/mirrors/create/qrep/snowflakeQrep.tsx
@@ -13,7 +13,6 @@ import { MirrorSetter } from '../../types';
 import { fetchAllTables } from '../handlers';
 import { MirrorSetting, blankSnowflakeQRepSetting } from '../helpers/common';
 import { snowflakeQRepSettings } from '../helpers/qrep';
-import QRepQuery from './query';
 
 interface SnowflakeQRepProps {
   mirrorConfig: QRepConfig;
@@ -82,20 +81,6 @@ export default function SnowflakeQRepForm({
   }, [setter]);
   return (
     <>
-      <Label>
-        Snowflake to PostgreSQL Query Replication currently only supports
-        full-table streaming replication with overwrite mode. More features
-        coming soon!
-      </Label>
-      <QRepQuery
-        query={mirrorConfig.query}
-        setter={(val: string) => {
-          setter((curr) => ({
-            ...curr,
-            query: val,
-          }));
-        }}
-      />
       {mirrorConfig.sourcePeer?.name ? (
         snowflakeQRepSettings.map((setting, id) => {
           return (