UI improvement For Harp (#1036)

Removes dynamic rendering forcing in a lot of places, adds some logs to grpc backend
PeerDB-io · Jan 9, 2024 · 9b04215 · 9b04215
1 parent 2a215a9
commit 9b04215
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 13 deletions.
diff --git a/flow/cmd/mirror_status.go b/flow/cmd/mirror_status.go
@@ -17,6 +17,7 @@ func (h *FlowRequestHandler) MirrorStatus(
 	ctx context.Context,
 	req *protos.MirrorStatusRequest,
 ) (*protos.MirrorStatusResponse, error) {
+	slog.Info("Mirror status endpoint called", slog.String(string(shared.FlowNameKey), req.FlowJobName))
 	cdcFlow, err := h.isCDCFlow(ctx, req.FlowJobName)
 	if err != nil {
 		return &protos.MirrorStatusResponse{
@@ -73,6 +74,7 @@ func (h *FlowRequestHandler) CDCFlowStatus(
 	ctx context.Context,
 	req *protos.MirrorStatusRequest,
 ) (*protos.CDCMirrorStatus, error) {
+	slog.Info("CDC mirror status endpoint called", slog.String(string(shared.FlowNameKey), req.FlowJobName))
 	config, err := h.getFlowConfigFromCatalog(req.FlowJobName)
 	if err != nil {
 		return nil, err
@@ -172,6 +174,7 @@ func (h *FlowRequestHandler) QRepFlowStatus(
 	ctx context.Context,
 	req *protos.MirrorStatusRequest,
 ) (*protos.QRepMirrorStatus, error) {
+	slog.Info("QRep Flow status endpoint called", slog.String(string(shared.FlowNameKey), req.FlowJobName))
 	partitionStatuses, err := h.getPartitionStatuses(ctx, req.FlowJobName)
 	if err != nil {
 		slog.Error(fmt.Sprintf("unable to query qrep partition - %s: %s", req.FlowJobName, err.Error()))

diff --git a/ui/app/api/alert-config/route.ts b/ui/app/api/alert-config/route.ts
@@ -1,8 +1,6 @@
 import { alertConfigType } from '@/app/alert-config/validation';
 import prisma from '@/app/utils/prisma';
 
-export const dynamic = 'force-dynamic';
-
 export async function GET() {
   const configs = await prisma.alerting_config.findMany();
   const serializedConfigs = configs.map((config) => ({

diff --git a/ui/app/api/mirrors/alerts/route.ts b/ui/app/api/mirrors/alerts/route.ts
@@ -1,7 +1,5 @@
 import prisma from '@/app/utils/prisma';
 
-export const dynamic = 'force-dynamic';
-
 export async function POST(request: Request) {
   const { flowName } = await request.json();
   const errCount = await prisma.flow_errors.count({

diff --git a/ui/app/mirrors/edit/[mirrorId]/page.tsx b/ui/app/mirrors/edit/[mirrorId]/page.tsx
@@ -8,8 +8,6 @@ import { CDCMirror } from './cdc';
 import NoMirror from './nomirror';
 import SyncStatus from './syncStatus';
 
-export const dynamic = 'force-dynamic';
-
 type EditMirrorProps = {
   params: { mirrorId: string };
 };

diff --git a/ui/app/mirrors/page.tsx b/ui/app/mirrors/page.tsx
@@ -13,8 +13,6 @@ import useSWR from 'swr';
 import { fetcher } from '../utils/swr';
 import { CDCFlows, QRepFlows } from './tables';
 
-export const dynamic = 'force-dynamic';
-
 export default function Mirrors() {
   const {
     data: flows,

diff --git a/ui/app/mirrors/status/qrep/[mirrorId]/page.tsx b/ui/app/mirrors/status/qrep/[mirrorId]/page.tsx
@@ -5,8 +5,6 @@ import QRepConfigViewer from './qrepConfigViewer';
 import QrepGraph from './qrepGraph';
 import QRepStatusTable, { QRepPartitionStatus } from './qrepStatusTable';
 
-export const dynamic = 'force-dynamic';
-
 type QRepMirrorStatusProps = {
   params: { mirrorId: string };
 };

diff --git a/ui/app/mirrors/status/qrep/[mirrorId]/qrepConfigViewer.tsx b/ui/app/mirrors/status/qrep/[mirrorId]/qrepConfigViewer.tsx
@@ -5,8 +5,6 @@ import { Icon } from '@/lib/Icon';
 import { Label } from '@/lib/Label';
 import { ProgressCircle } from '@/lib/ProgressCircle';
 
-export const dynamic = 'force-dynamic';
-
 type QRepConfigViewerProps = {
   mirrorId: string;
 };

diff --git a/ui/app/peers/[peerName]/page.tsx b/ui/app/peers/[peerName]/page.tsx
@@ -5,7 +5,6 @@ import { GetFlowHttpAddressFromEnv } from '@/rpc/http';
 import Link from 'next/link';
 import SlotTable from './slottable';
 import StatTable from './stattable';
-export const dynamic = 'force-dynamic';
 
 type DataConfigProps = {
   params: { peerName: string };