Skip to content

Commit

Permalink
column exclusion: include checking c1. debug logging this last test
Browse files Browse the repository at this point in the history
  • Loading branch information
serprex committed Jan 6, 2024
1 parent d7c329a commit a9ced64
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion flow/e2e/bigquery/peer_flow_bq_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1526,7 +1526,7 @@ func (s PeerFlowE2ETestSuiteBQ) Test_Soft_Delete_UD_Same_Batch() {
require.NoError(s.t, err)

connectionGen := e2e.FlowConnectionGenerationConfig{
FlowJobName: s.attachSuffix("test_softdel_ud"),
FlowJobName: s.attachSuffix(dstName),
}

config := &protos.FlowConnectionConfigs{
Expand Down Expand Up @@ -1587,6 +1587,8 @@ func (s PeerFlowE2ETestSuiteBQ) Test_Soft_Delete_UD_Same_Batch() {
return false
}

newrows, _ := s.GetRows(dstName, "id,c1,c2,t")
s.t.Log("rows same", rows.NumRecords, newrows.NumRecords)
newerSyncedAtQuery := fmt.Sprintf(
"SELECT COUNT(*) FROM `%s.%s` WHERE _PEERDB_IS_DELETED",
s.bqHelper.datasetName, dstName)
Expand Down
4 changes: 2 additions & 2 deletions flow/e2e/snowflake/peer_flow_sf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1237,13 +1237,13 @@ func (s PeerFlowE2ETestSuiteSF) Test_Column_Exclusion() {
}
s.t.Log("Inserted 10 rows into the source table")

e2e.EnvWaitForEqualTables(env, s, "normalize table", tableName, "id,t,t2")
e2e.EnvWaitForEqualTables(env, s, "normalize table", tableName, "id,c1,t,t2")
_, err = s.pool.Exec(context.Background(),
fmt.Sprintf(`UPDATE %s SET c1=c1+1 WHERE MOD(c2,2)=1`, srcTableName))
e2e.EnvNoError(s.t, env, err)
_, err = s.pool.Exec(context.Background(), fmt.Sprintf(`DELETE FROM %s WHERE MOD(c2,2)=0`, srcTableName))
e2e.EnvNoError(s.t, env, err)
e2e.EnvWaitForEqualTables(env, s, "normalize update/delete", tableName, "id,t,t2")
e2e.EnvWaitForEqualTables(env, s, "normalize update/delete", tableName, "id,c1,t,t2")

env.CancelWorkflow()
}()
Expand Down

0 comments on commit a9ced64

Please sign in to comment.