[dropflow] delete flow configs only after finish drop (#2281)

PeerDB-io · Nov 22, 2024 · cf14792 · cf14792
1 parent 60c2744
commit cf14792
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/flow/workflows/drop_flow.go b/flow/workflows/drop_flow.go
@@ -92,6 +92,15 @@ func DropFlowWorkflow(ctx workflow.Context, input *protos.DropFlowInput) error {
 		}
 	}
 
+	if input.FlowConnectionConfigs != nil {
+		err := executeCDCDropActivities(ctx, input)
+		if err != nil {
+			workflow.GetLogger(ctx).Error("failed to drop CDC flow", slog.Any("error", err))
+			return err
+		}
+		workflow.GetLogger(ctx).Info("CDC flow dropped successfully")
+	}
+
 	removeFlowEntriesCtx := workflow.WithActivityOptions(ctx, workflow.ActivityOptions{
 		StartToCloseTimeout: 1 * time.Minute,
 	})
@@ -103,14 +112,5 @@ func DropFlowWorkflow(ctx workflow.Context, input *protos.DropFlowInput) error {
 		return err
 	}
 
-	if input.FlowConnectionConfigs != nil {
-		err := executeCDCDropActivities(ctx, input)
-		if err != nil {
-			workflow.GetLogger(ctx).Error("failed to drop CDC flow", slog.Any("error", err))
-			return err
-		}
-		workflow.GetLogger(ctx).Info("CDC flow dropped successfully")
-	}
-
 	return nil
 }