Skip to content

Commit

Permalink
fix: enable support for TLS 1.2
Browse files Browse the repository at this point in the history
- fix for usage with confluent cloud
  • Loading branch information
iamKunalGupta committed Apr 25, 2024
1 parent f988899 commit e5b6b20
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions flow/connectors/kafka/kafka.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"crypto/tls"
"fmt"
"github.com/twmb/franz-go/plugin/kslog"

Check failure on line 7 in flow/connectors/kafka/kafka.go

View workflow job for this annotation

GitHub Actions / lint

File is not `gci`-ed with --skip-generated -s standard -s prefix(github.com/PeerDB-io) -s default (gci)
"log/slog"
"strings"
"sync"
Expand All @@ -13,7 +14,6 @@ import (
"github.com/twmb/franz-go/pkg/kgo"
"github.com/twmb/franz-go/pkg/sasl/plain"
"github.com/twmb/franz-go/pkg/sasl/scram"

Check failure on line 16 in flow/connectors/kafka/kafka.go

View workflow job for this annotation

GitHub Actions / lint

File is not `gci`-ed with --skip-generated -s standard -s prefix(github.com/PeerDB-io) -s default (gci)
"github.com/twmb/franz-go/plugin/kslog"
lua "github.com/yuin/gopher-lua"
"go.temporal.io/sdk/log"

Expand Down Expand Up @@ -45,7 +45,7 @@ func NewKafkaConnector(
kgo.SoftwareNameAndVersion("peerdb", peerdbenv.PeerDBVersionShaShort()),
)
if !config.DisableTls {
optionalOpts = append(optionalOpts, kgo.DialTLSConfig(&tls.Config{MinVersion: tls.VersionTLS13}))
optionalOpts = append(optionalOpts, kgo.DialTLSConfig(&tls.Config{MinVersion: tls.VersionTLS12}))
}
switch config.Partitioner {
case "LeastBackup":
Expand Down

0 comments on commit e5b6b20

Please sign in to comment.