Skip to content

Commit

Permalink
Fix regressed signals test
Browse files Browse the repository at this point in the history
Pause is now hard pause, so don't test that pause includes final sync
This part of test was a bit racy anyways
  • Loading branch information
serprex committed Mar 1, 2024
1 parent 904b513 commit e67ed3e
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions flow/e2e/postgres/peer_flow_pg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1215,9 +1215,6 @@ func (s PeerFlowE2ETestSuitePG) Test_Dynamic_Mirror_Config_Via_Signals() {
if !s.t.Failed() {
// wait for first RegisterDelayedCallback to hit.
e2e.EnvWaitFor(s.t, env, 1*time.Minute, "sent pause signal", func() bool {
// adding 1 more row while pausing - guarantee finishing another sync
addRows(1)

return sentPause
})
} else {
Expand Down Expand Up @@ -1258,10 +1255,6 @@ func (s PeerFlowE2ETestSuitePG) Test_Dynamic_Mirror_Config_Via_Signals() {
}, 56*time.Second)

go func() {
e2e.EnvWaitFor(s.t, env, 1*time.Minute, "normalize 1 record - first table", func() bool {
return s.comparePGTables(srcTable1Name, dstTable1Name, "id,t") == nil
})

// we have a paused mirror, wait for second signal to hit.
e2e.EnvWaitFor(s.t, env, 1*time.Minute, "sent updates signal", func() bool {
return sentUpdate
Expand Down

0 comments on commit e67ed3e

Please sign in to comment.