Remove SyncOptionsSignal

This did not get wired up in sync_flow.go, but rather than implement it, remove it We're moving towards requiring all option updates to require pausing first anyways
PeerDB-io · Mar 4, 2024 · e8e1421 · e8e1421
1 parent 39c6e7e
commit e8e1421
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/flow/model/signals.go b/flow/model/signals.go
@@ -138,10 +138,6 @@ var SyncResultSignal = TypedSignal[*SyncResponse]{
 	Name: "sync-result",
 }
 
-var SyncOptionsSignal = TypedSignal[*protos.SyncFlowOptions]{
-	Name: "sync-options",
-}
-
 var NormalizeSignal = TypedSignal[NormalizePayload]{
 	Name: "normalize",
 }

diff --git a/flow/workflows/cdc_flow.go b/flow/workflows/cdc_flow.go
@@ -164,10 +164,6 @@ func (w *CDCFlowWorkflowExecution) processCDCFlowConfigUpdate(ctx workflow.Conte
 
 		state.SyncFlowOptions.TableMappings = append(state.SyncFlowOptions.TableMappings, flowConfigUpdate.AdditionalTables...)
 
-		if w.syncFlowFuture != nil {
-			_ = model.SyncOptionsSignal.SignalChildWorkflow(ctx, w.syncFlowFuture, state.SyncFlowOptions).Get(ctx, nil)
-		}
-
 		// finished processing, wipe it
 		state.FlowConfigUpdate = nil
 	}
@@ -191,10 +187,6 @@ func (w *CDCFlowWorkflowExecution) addCdcPropertiesSignalListener(
 		// do this irrespective of additional tables being present, for auto unpausing
 		state.FlowConfigUpdate = cdcConfigUpdate
 
-		if w.syncFlowFuture != nil {
-			_ = model.SyncOptionsSignal.SignalChildWorkflow(ctx, w.syncFlowFuture, state.SyncFlowOptions).Get(ctx, nil)
-		}
-
 		w.logger.Info("CDC Signal received. Parameters on signal reception:",
 			slog.Int("BatchSize", int(state.SyncFlowOptions.BatchSize)),
 			slog.Int("IdleTimeout", int(state.SyncFlowOptions.IdleTimeoutSeconds)),