Skip to content

Commit

Permalink
fix log and style
Browse files Browse the repository at this point in the history
  • Loading branch information
Amogh-Bharadwaj committed Nov 16, 2023
1 parent f096654 commit fa11e9f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion flow/connectors/external_metadata/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ type PostgresMetadataStore struct {
func NewPostgresMetadataStore(ctx context.Context, pgConfig *protos.PostgresConfig,
schemaName string) (*PostgresMetadataStore, error) {
connectionString := utils.GetPGConnectionString(pgConfig)
log.Info("connection string in external metadata: ", connectionString)
pool, err := pgxpool.New(ctx, connectionString)
if err != nil {
log.Errorf("failed to create connection pool: %v", err)
Expand Down
5 changes: 2 additions & 3 deletions flow/connectors/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,14 @@ func (c *S3Connector) Close() error {
return nil
}

func ValidCheck(s3Client *s3.S3, bucketUrl string, metadataDB *metadataStore.PostgresMetadataStore) error {
func ValidCheck(s3Client *s3.S3, bucketURL string, metadataDB *metadataStore.PostgresMetadataStore) error {
_, listErr := s3Client.ListBuckets(nil)
if listErr != nil {
return fmt.Errorf("failed to list buckets: %w", listErr)
}

reader := strings.NewReader("hello world")

bucketPrefix, parseErr := utils.NewS3BucketAndPrefix(bucketUrl)
bucketPrefix, parseErr := utils.NewS3BucketAndPrefix(bucketURL)
if parseErr != nil {
return fmt.Errorf("failed to parse bucket url: %w", parseErr)
}
Expand Down

0 comments on commit fa11e9f

Please sign in to comment.