Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeartbeatRoutine: return cancel func instead of chan struct{} #1021

Merged
merged 1 commit into from
Jan 8, 2024
Merged

HeartbeatRoutine: return cancel func instead of chan struct{} #1021

merged 1 commit into from
Jan 8, 2024

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Jan 7, 2024

#1020 reverted #997

Reimplement so only func declaration moves into HeartbeatRoutine

@serprex
HeartbeatRoutine: return cancel func instead of chan struct{}
a40d8eb 
only moving func declaration into HeartbeatRoutine
@serprex serprex enabled auto-merge (squash) January 7, 2024 23:59
@serprex serprex merged commit ef2ed57 into main Jan 8, 2024
@serprex serprex deleted the shutdown-2 branch February 14, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@heavycrystal heavycrystal Awaiting requested review from heavycrystal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serprex @iskakaushik