Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BQ: Handle NaN in Merge #1031

Merged
merged 1 commit into from
Jan 9, 2024
Merged

BQ: Handle NaN in Merge #1031

merged 1 commit into from
Jan 9, 2024

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Jan 9, 2024

json.Marshall does not support NaN , so we have to nullfy them, but:
NULLs are aren't allowed when inserting arrays in bigquery.
So in the Merge statement we skip nulls
Fixes #1029

@iskakaushik
Copy link
Contributor

@Amogh-Bharadwaj can you file an issue to check if this is a problem for Snowflake as well?

@Amogh-Bharadwaj Amogh-Bharadwaj merged commit 76e92f4 into main Jan 9, 2024
7 checks passed
@serprex serprex deleted the datatypes/bq-nan branch July 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: Add tests for NaNs in Floats and Float Arrays
2 participants