Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventhub: Fix rows synced log #1053

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Eventhub: Fix rows synced log #1053

merged 1 commit into from
Jan 11, 2024

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Jan 11, 2024

We weren't returning the current sync batch ID as part of eventhub's SyncRecords. The monitoring function for CDC details filters based on batch ID and updates rows synced. As a result, we weren't able to get CDC logs for Eventhub. This PR fixes that

@serprex
Copy link
Contributor

serprex commented Jan 11, 2024

PR description should be revised since you seem to've redesigned PR

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you update description

@Amogh-Bharadwaj Amogh-Bharadwaj merged commit e045b4c into main Jan 11, 2024
7 checks passed
@serprex serprex deleted the eh/fix-rows-synced-log branch July 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants