[breaking] pruning and reorganizing fields from protos, moving stuff to state #1087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs several breaking changes to our protobufs:
FlowConnectionConfigs
:table_schema, src_table_id_name_mapping, table_name_schema_mapping, snapshot_sync_mode, cdc_sync_mode, push_batch_size, push_parallelism, metadata_peer
.src_table_id_name_mapping
andtable_name_schema_mapping
are now moved to state, setup fromSetupFlow
and passed accordingly via more proto changes. Order shuffled around to group similar fields together.table_identifier
EnsurePullabilityInput
andEnsurePullabilityOutput
do_initial_copy
andinitial_copy_only
to better align with other options.columns
fromTableSchema
and fixed related methods up.batch_size
had 3 different datatypes and was being modified in multiple places, making surebatch_size
andidle_timeout_seconds
has one source of truth.