Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more data types #1089

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Support more data types #1089

merged 9 commits into from
Jan 17, 2024

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Jan 16, 2024

This PR adds support for the following types across PG, SF and BQ:

  • Array of Boolean
  • Array of Date
  • Array of Timestamp(/TZ)
  • Array of Int16 (smallint)
  • CIDR
  • MacAddr
  • INET

The latter 3 is more relevant for Postgres.
This PR achieves the correct AVRO type mapping for Date in BigQuery - eliminating the hack which was being done in merge transforms.
This PR also writes date and time values as human readable text for BQ QRep

Tests added as well

Fixes #666
Fixes #20

iskakaushik added a commit to PeerDB-io/docs that referenced this pull request Jan 17, 2024
Introduces a document outlining our datatype support in detail.

This can be merged once PeerDB-io/peerdb#1091
and PeerDB-io/peerdb#1089 land

---------

Co-authored-by: Kaushik Iska <[email protected]>
@Amogh-Bharadwaj Amogh-Bharadwaj merged commit 84aaef2 into main Jan 17, 2024
7 checks passed
@serprex serprex deleted the datatypes/more-types branch July 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants