[snowflake] Cache information schema queries on snowflake #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases there are thousands of tables, PeerDB runs A LOT of INFORMATION_SCHEMA queries to Snowflake’s INFORMATION_SCHEMA which counts as Cloud Service usage. This results in very high credit consumption w/ ~1:25 ratio of regular credit consumed to cloud services credits consumed (see screenshot) — so even if an XSMALL or SMALL warehouse is used (1, 2 credits/hour respectively) we still end up consuming ~50 credits an hour.
serprex
reviewed
Jan 17, 2024
| func (c *SnowflakeInformationSchemaCache) SchemaExists(schemaName string) (bool, error) { | ||
| schemaName = strings.ToUpper(schemaName) | ||
|
|
||
| if cachedExists, ok := cache.schemaExistsCache.Get(schemaName); ok { |
There was a problem hiding this comment.
bit unfortunate that they made an LRU expirable cache without an atomic GetOrUpsert method
|
should probably generalize this for bigquery |
serprex
requested changes
Jan 17, 2024
serprex
reviewed
Jan 17, 2024
serprex
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases there are thousands of tables, PeerDB runs A LOT of INFORMATION_SCHEMA queries to Snowflake’s INFORMATION_SCHEMA which counts as Cloud Service usage. This results in very high credit consumption w/ ~1:25 ratio of regular credit consumed to cloud services credits consumed (see screenshot) — so even if an XSMALL or SMALL warehouse is used (1, 2 credits/hour respectively) we still end up consuming ~50 credits an hour.