Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[snowflake] Cache information schema queries on snowflake" #1093

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Jan 17, 2024

Caching is running into issues with things like

CREATE MIRROR
CREATE TARGET SCHEMA
DROP MIRROR
DROP TARGET SCHEMA
CREATE TARGET SCHEMA
CREATE MIRROR

where cache tricks system into thinking metadata tables exist & the system gets stuck trying to use tables it thinks it upsert

Possible there's other issues, but caching needs to be thought over to address:

  1. invalidate cache on specific errors
  2. either have code bypass cache or make sure the code doesn't rely on the information being fresh
  3. whole system being built to recover/resync better

@serprex serprex requested a review from iskakaushik January 17, 2024 23:30
@serprex serprex enabled auto-merge (squash) January 17, 2024 23:44
@serprex serprex disabled auto-merge January 17, 2024 23:45
@serprex serprex merged commit c372ad6 into main Jan 17, 2024
7 checks passed
@serprex serprex deleted the revert-1092-snowflake-is-cache branch February 5, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants