Support specifying host key for ssh config #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
ssh-host-key
branch
2 times, most recently
from
109712d to
0877301
Compare
|
As an aside, I don't like how we take private key as input. Granted, this works for when the user wants to generate everything on their end, but the ideal would be that the user doesn't even have access to the private key: we would generate a private key in handler, & give back public key to user. That'd also enforce private key never traversing internet |
Amogh-Bharadwaj
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty host key interpreted as accept-all
Fixes #804
UX would be greatly improved by implementing a "load host key" button which has server request host key from remote server & fill in ui field
Host keys can be acquired with
ssh-keyscan $HOST