Remove CDCRecordStream SchemaDeltas #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead RelationRecord is passed in with rest of Records, where connectors handle collecting schema deltas
|
Little silly passing these records down when we could append to a slice held in |
|
Closing in favor of #1135 |
serprex
added a commit
that referenced
this pull request
Jan 24, 2024
Simpler alternative to #1134 Particularly convenient having exclusion info already transformed into maps/sets in pull connector Idea is that `CDCRecordStream` is a synchronization object. While `Records` is open everything is written to only by pull connector, we only receive records out Records channel. Pull connector relieves write access once `Records` closed, allowing everything else to read out the rest. In this regard `lastCheckpointSet` is unnecessary & I eventually intend to get rid of it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead
RelationRecordis passed in with rest ofRecords,where connectors handle collecting schema deltas