nexus: impl QueryExecutor for Catalog #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To share code, Catalog was storing a postgres query executor Unfortunately, that caused two connections for every nexus connection Remove is_connection_valid since it isn't used, & for pg was wrong (see deadpool-postgres for how they check if connection is valid) Alternative fix would've been to use more connection pools, that could be added in the future if necessary
serprex
force-pushed
the
nexus-catalog-pool
branch
from
d7794f0 to
842134b
Compare
iskakaushik
reviewed
Jan 25, 2024
iskakaushik
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To share code, Catalog was storing a postgres query executor
Unfortunately, that caused two connections for every nexus connection
Remove is_connection_valid since it isn't used, & for pg was wrong
(see deadpool-postgres for how they check if connection is valid)
Alternative fix would've been to use more connection pools,
that could be added in the future if necessary