Remove ShutdownSignal #1160
Merged
Remove ShutdownSignal #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
shutdown-is-cancel
branch
from
615c4b0 to
b8d53bc
Compare
The idea behind ShutdownSignal is that we can use signals to gracefully stop workflows, in practice this doesn't work 1. DROP MIRROR is a 1 minute timeout for shutdown to stop workflow, in cdc I had us cut off early, but even waiting for normalize to finish is too much for 1 minute 2. Signal isn't checked by flows until they reach main loop, in theory they could check, but in effect you're doubling the existing context error code Solution: go straight to workflow cancelation. If graceful shutdown is desired, pause mirror before drop
serprex
force-pushed
the
shutdown-is-cancel
branch
from
b8d53bc to
6fcaf38
Compare
iskakaushik
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind ShutdownSignal is that we can use signals to gracefully stop workflows,
in practice this doesn't work
Solution: go straight to workflow cancelation. If graceful shutdown is desired (ie, finishing current syncs, finishing normalization), pause mirror before drop