postgres connector: replace pgxpool.Pool with pgx.Conn #1163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently create a pool per connector. This is not generally useful. Connection pools are best when you have one pool for the entire application, such as what we do for the catalog pool. Change connector to use
pgx.Conn
as connectors should not generally be used in a multithreaded wayIn situations where you need a 2nd connection the pool would end up creating that 2nd connection, & in most scenarios that 2nd connection should be short lived (eg, 5 minute slot info checks) instead of having them idle most of the time