Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for UI and general #1197

Merged
merged 6 commits into from
Feb 4, 2024
Merged

fixes for UI and general #1197

merged 6 commits into from
Feb 4, 2024

Conversation

heavycrystal
Copy link
Contributor

@heavycrystal heavycrystal commented Feb 1, 2024 •
edited
Loading

  1. TableMappings is now cloned and stored in state, and modifications affect only state version. Pass it through to SyncFlow.
  2. Fixed some logs
  3. removed env var for idle timeout seconds, but retaining function for tests.
  4. Renamed mispelt proto field.
  5. bug in UI, wasn't looking at the correct version of additionalTables
  6. optimization - don't store records from CDC in some cases
  7. don't heartbeat after every record.

@heavycrystal heavycrystal requested a review from serprex February 1, 2024 22:07
Amogh-Bharadwaj
Amogh-Bharadwaj approved these changes Feb 1, 2024
View reviewed changes
@heavycrystal heavycrystal requested a review from serprex February 3, 2024 11:59
@iskakaushik iskakaushik merged commit 169112a into main Feb 4, 2024
12 checks passed
@iskakaushik iskakaushik deleted the edit-mirror-ui-fixes branch February 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amogh-Bharadwaj Amogh-Bharadwaj Amogh-Bharadwaj approved these changes

@serprex serprex Awaiting requested review from serprex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heavycrystal @serprex @Amogh-Bharadwaj @iskakaushik