Eventhubs: Refactor Destination Table Semantics #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Feb 2, 2024
| // It's just so that we have distinct destination table names | ||
| // in create mirror's table mapping. | ||
| // We can ignore it. | ||
| eventhubPart := strings.Trim(parts[0], `"`) |
There was a problem hiding this comment.
These parts would ideally be sent as []string in protocol, avoid this incorrect parsing
Otherwise we need to correctly consume double quoted identifiers so that identifiers with . don't break things
iskakaushik
approved these changes
Feb 4, 2024
|
landing for customer urgency |
Amogh-Bharadwaj
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit f9fa222.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destination table name in table mapping of Create CDC Mirror now expected to look like:
This is to allow multiple source tables to be mapped to same eventhub partition.
unique identifiercan be the source table name or anything else. It's purely to distinguish destination table names