dynamic properties test #1216
Merged
dynamic properties test #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test doesn't pass in a container, tried with Docker. |
heavycrystal
changed the title
serprex
previously approved these changes
Feb 8, 2024
serprex
reviewed
Feb 8, 2024
serprex
reviewed
Feb 8, 2024
| // 3 from first insert of 18 rows in 1 table | ||
| // 1 from pre-pause | ||
| // 3 from second insert of 18 rows in 2 tables, batch size updated | ||
| require.GreaterOrEqual(s.t, len(workflowState.SyncFlowStatuses), 3+1+3) |
There was a problem hiding this comment.
Cannot call require functions in goroutines; instead compare & then use s.t.Fail or use e2e.Env... helper functions
serprex
reviewed
Feb 8, 2024
serprex
reviewed
Feb 12, 2024
serprex
approved these changes
Feb 12, 2024
heavycrystal
force-pushed
the
dynprops-test-debug
branch
from
400ab81 to
1b09e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also ends up testing initial load