BQ merge fixes #1241
Merged
BQ merge fixes #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heavycrystal
reviewed
Feb 9, 2024
heavycrystal
approved these changes
Feb 9, 2024
serprex
force-pushed
the
array-chunks-edgecase
branch
3 times, most recently
from
1b4e5e2 to
6968360
Compare
BQ `it.Next(&row)` seems to mutate the target, https://github.com/googleapis/google-cloud-go/blob/f049c9751415f9fc4c81c1839a8371782cfc016c/bigquery/value.go#L490 so reallocate a fresh row each iteration ArrayChunks: replace with ArrayIterChunks. Document behavior when input is empty slice This reduces allocations, since we've seen people having 1000+ columns go 1.22 has a rangefunc experiment, so eventually we can replace this with that https://go.dev/wiki/RangefuncExperiment
serprex
force-pushed
the
array-chunks-edgecase
branch
from
6968360 to
75f15b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BQ
it.Next(&row)seems to mutate the target,https://github.com/googleapis/google-cloud-go/blob/f049c9751415f9fc4c81c1839a8371782cfc016c/bigquery/value.go#L490
so reallocate a fresh row each iteration
ArrayChunks: replace with ArrayIterChunks. Document behavior when input is empty slice
Also reduces allocations, since we've seen people having 1000+ columns
go 1.22 has a rangefunc experiment, so eventually we can replace this with that https://go.dev/wiki/RangefuncExperiment