Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace more use of default slog handler with logger from context #1253

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Feb 11, 2024

Things are getting a bit messy since while temporalio/sdk-go#1158 claims the interfaces are compatible in reality there's a mess about what the two different implementations expect from args ...interface{}

For now use context specific logger more to mangle output less in CI. A more correct/complete solution will have to be worked out in future

@serprex serprex merged commit e5eb347 into main Feb 11, 2024
6 of 7 checks passed
@serprex serprex deleted the less-slog branch February 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants