Filter out invalid BigQuery timestamps #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Feb 12, 2024
serprex
reviewed
Feb 12, 2024
serprex
reviewed
Feb 12, 2024
serprex
reviewed
Feb 12, 2024
Amogh-Bharadwaj
force-pushed
the
bigquery/filter-invalid-timestamps
branch
from
3496c1c to
882194b
Compare
serprex
previously approved these changes
Feb 14, 2024
serprex
reviewed
Feb 14, 2024
serprex
reviewed
Feb 14, 2024
serprex
reviewed
Feb 14, 2024
|
updated description |
serprex
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254
Adds a test for it in QRep
Also we are nulling out and logging values of time/timestamps which cannot be scanned by pgx (time.Time). An example is a year with more than 4 digits