Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor s3 wiring for clickhouse #1265

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Refactor s3 wiring for clickhouse #1265

merged 6 commits into from
Feb 13, 2024

Conversation

Amogh-Bharadwaj
Copy link
Contributor

Now requires one of the two:

  1. Env variables for S3 credentials
  2. S3 credentials from clickhouse peer which are now optional in UI

For the former, the bucket path is constructed by bucket-name/deployment-uid/flowname

@Amogh-Bharadwaj Amogh-Bharadwaj force-pushed the ui/clickhouse-abstract-s3 branch from e4fa6ba to deca6fd Compare February 12, 2024 23:54
serprex
serprex previously approved these changes Feb 13, 2024
View reviewed changes
@serprex serprex dismissed their stale review February 13, 2024 01:01

tls removed

@iskakaushik iskakaushik merged commit 516e384 into main Feb 13, 2024
10 of 11 checks passed
@iskakaushik iskakaushik deleted the ui/clickhouse-abstract-s3 branch February 13, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amogh-Bharadwaj @serprex @iskakaushik