CreateNormalizedTable: lift loop, make it based on separate connector #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce a generalized GetConnectorAs, use internally for existing functions
serprex
force-pushed
the
heartbeat-in-setup-normalized
branch
from
91e623f to
0840060
Compare
iskakaushik
reviewed
Feb 13, 2024
flow/activities/flowable.go
Outdated
| } | ||
| defer conn.AbortSetupNormalizedTables(ctx, tx) |
There was a problem hiding this comment.
defer aborts feels like we will always Abort. I'm wondering if there is a way to say this RollbackIfError or something,
There was a problem hiding this comment.
Considered MaybeRollback but went with Cleanup to keep it a general "defer cleanup of whatever your tx object is"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake was sending a heartbeat for each table, BQ was using HeartbeatRoutine, clickhouse wasn't sending heartbeats. Unify on HeartbeatRoutine
Move to a separate connector interface so s3/eventhubs etc don't need to implement the start/abort/finish methods as stubs too
Also introduce a generalized GetConnectorAs, use internally for existing functions