Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate mirror: check replication connectivity, move to validate.go #1300

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Validate mirror: check replication connectivity, move to validate.go #1300

merged 2 commits into from
Feb 15, 2024

Conversation

Amogh-Bharadwaj
Copy link
Contributor

Fixes #746
Moves all validation related functions in client.go to a new validate.go for better organisation

iskakaushik
iskakaushik requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the connections closed everywhere after validation?

@Amogh-Bharadwaj Amogh-Bharadwaj merged commit cc3afe8 into main Feb 15, 2024
7 checks passed
@Amogh-Bharadwaj Amogh-Bharadwaj deleted the validate-mirror/repl-conn branch February 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex approved these changes

@iskakaushik iskakaushik iskakaushik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate Mirror should check if we can establish a replication connection for postgres
3 participants
@Amogh-Bharadwaj @serprex @iskakaushik