Improve api for UI #1304
Merged
Improve api for UI #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Amogh-Bharadwaj
commented
Feb 15, 2024
Amogh-Bharadwaj
commented
- Replication connection can't perform queries so removed that
- Exclude dropped columns from being displayed in table picker
- Refactor create pub check to check privileges since transactions don't work on publications and don't want to risk creating and not dropping one. this has been functionally tested
serprex
reviewed
Feb 15, 2024
Co-authored-by: Philip Dubé <[email protected]>
serprex
reviewed
Feb 15, 2024
remove dead code
serprex
approved these changes
Feb 15, 2024
serprex
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.