refactor fetching and pushing of last offset #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Amogh-Bharadwaj
commented
Feb 19, 2024
•
Amogh-Bharadwaj
commented
- Moves getting of last offset to start flow and removes from peer flow
iskakaushik
approved these changes
Feb 19, 2024
serprex
reviewed
Feb 19, 2024
| } | ||
|
|
||
| msg := fmt.Sprintf("last synced ID from destination peer - %d\n", lastOffset) | ||
| slog.InfoContext(ctx, msg) |
There was a problem hiding this comment.
use logger.LoggerFromCtx
|
This is done in #1211 also, good to split it out, can remove the proto too |
|
this is for a customer |
iskakaushik
reviewed
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.