making UX for edit mirror simpler #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heavycrystal
commented
Feb 20, 2024
heavycrystal
commented
- Edit Mirror button is completely disabled unless mirror is paused.
- Automatic unpausing once we finish processing config update.
- Labels to convey automatic unpausing
heavycrystal
force-pushed
the
edit-mirror-simpler-ux
branch
2 times, most recently
from
6947ad0 to
48d88db
Compare
serprex
reviewed
Feb 21, 2024
flow/workflows/cdc_flow.go
Outdated
| err = w.processCDCFlowConfigUpdates(ctx, cfg, state, mirrorNameSearch) | ||
| if err != nil { | ||
| return state, err | ||
| } | ||
| // explicitly unpause | ||
| state.ActiveSignal = shared.NoopSignal |
There was a problem hiding this comment.
arguably unpausing should be a pool on edit request
serprex
approved these changes
Feb 21, 2024
heavycrystal
force-pushed
the
edit-mirror-simpler-ux
branch
from
48d88db to
e351f4c
Compare
heavycrystal
added a commit
that referenced
this pull request
Feb 29, 2024
This reverts commit b6eb5d1.
iskakaushik
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.