Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QRep: Add test for no rows mirror #1396

Merged
merged 1 commit into from
Feb 28, 2024
Merged

QRep: Add test for no rows mirror #1396

merged 1 commit into from
Feb 28, 2024

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Feb 28, 2024 •
edited
Loading

Adds a test for syncing an empty table via QRep.
This PR is to address this comment

The test successfully caught the error which was seen pre-patch:

        qrep_flow_pg_test.go:340: 
                Error Trace: peerdb/flow/e2e/postgres/qrep_flow_pg_test.go:340
                Error:          Received unexpected error:
                                workflow execution error (type: QRepFlowWorkflow, workflowID: default-test-workflow-id, runID: default-test-run-id): 
runtime error: integer divide by zero

@Amogh-Bharadwaj Amogh-Bharadwaj mentioned this pull request Feb 28, 2024
Merged
@Amogh-Bharadwaj Amogh-Bharadwaj merged commit efdffa2 into main Feb 28, 2024
7 checks passed
@Amogh-Bharadwaj Amogh-Bharadwaj deleted the test-no-rows branch February 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@serprex serprex serprex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amogh-Bharadwaj @serprex @iskakaushik