qrep: stop pulling records if sync completes #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
cancel-pull-when-sync-completes
branch
from
fbdefa3 to
4718583
Compare
iskakaushik
approved these changes
Feb 29, 2024
avoids pull continuing after sync returns 0 records
serprex
force-pushed
the
cancel-pull-when-sync-completes
branch
from
4718583 to
ca23b03
Compare
iskakaushik
pushed a commit
that referenced
this pull request
Feb 29, 2024
Avoids context.Canceled error being wrapped mixup in #1407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids pull continuing after sync returns 0 records
also stop syncing records if pull records hits error