feat: add telemetry/alerts via sns #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamKunalGupta
force-pushed
the
feat/add-telemetry-for-monitoring
branch
from
4d9ecb1 to
4f6b049
Compare
iamKunalGupta
changed the title
serprex
reviewed
Feb 29, 2024
serprex
approved these changes
Feb 29, 2024
iskakaushik
reviewed
Mar 1, 2024
iskakaushik
reviewed
Mar 1, 2024
iskakaushik
reviewed
Mar 1, 2024
iskakaushik
reviewed
Mar 1, 2024
iamKunalGupta
force-pushed
the
feat/add-telemetry-for-monitoring
branch
from
6463891 to
1d73e87
Compare
iamKunalGupta
force-pushed
the
feat/add-telemetry-for-monitoring
branch
from
1d73e87 to
33fa24d
Compare
heavycrystal
approved these changes
Mar 1, 2024
serprex
reviewed
Mar 1, 2024
|
|
||
| func NewSNSMessageSenderWithNewClient(ctx context.Context, config *SNSMessageSenderConfig) (SNSMessageSender, error) { | ||
| // Topic Region must match client region | ||
| region := strings.Split(strings.TrimPrefix(config.Topic, "arn:aws:sns:"), ":")[0] |
There was a problem hiding this comment.
Use strings.Cut: https://pkg.go.dev/strings#Cut
May also want strings.CutPrefix with error if Topic is lacking prefix
- also attempt to add information from context
iamKunalGupta
force-pushed
the
feat/add-telemetry-for-monitoring
branch
from
a935a42 to
a616dc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.