Bigquery: Support JSON, FLOAT PKey For Merge #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
changed the title
serprex
reviewed
Mar 1, 2024
serprex
reviewed
Mar 1, 2024
serprex
reviewed
Mar 1, 2024
serprex
reviewed
Mar 1, 2024
|
Passing all tests except the dynamic signals one |
Amogh-Bharadwaj
changed the title
serprex
approved these changes
Mar 1, 2024
serprex
pushed a commit
that referenced
this pull request
Mar 1, 2024
Float, JSON (and other [non-groupable types in bigquery](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#groupable_data_types )) as primary key is not supported by our merge statement in BigQuery as during our primary key comparison, BigQuery cannot compare, for example, JSON values: ``` googleapi: Error 400: Equality is not defined for arguments of type JSON ``` This PR makes a step towards supporting such columns in primary keys for BigQuery merge by transforming it to string there for `PARTITION BY` and comparison Test added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Float, JSON (and other non-groupable types in bigquery) as primary key is not supported by our merge statement in BigQuery as during our primary key comparison, BigQuery cannot compare, for example, JSON values:
This PR makes a step towards supporting such columns in primary keys for BigQuery merge by transforming it to string there for
PARTITION BYand comparisonTest added