Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressed signals test #1417

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Fix regressed signals test #1417

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f9f89f
Fix regressed signals test
serprex Mar 1, 2024
b74ed9a
wait longer on 2nd table
serprex Mar 1, 2024
605e399
Bigquery: Support JSON, FLOAT PKey For Merge (#1415)
Amogh-Bharadwaj Mar 1, 2024
003afa2
print comparison error
serprex Mar 1, 2024
08b0603
give up
serprex Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions flow/e2e/postgres/peer_flow_pg_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,9 +1215,6 @@ func (s PeerFlowE2ETestSuitePG) Test_Dynamic_Mirror_Config_Via_Signals() {
if !s.t.Failed() {
// wait for first RegisterDelayedCallback to hit.
e2e.EnvWaitFor(s.t, env, 1*time.Minute, "sent pause signal", func() bool {
// adding 1 more row while pausing - guarantee finishing another sync
addRows(1)

return sentPause
})
} else {
Expand Down Expand Up @@ -1258,10 +1255,6 @@ func (s PeerFlowE2ETestSuitePG) Test_Dynamic_Mirror_Config_Via_Signals() {
}, 56*time.Second)

go func() {
e2e.EnvWaitFor(s.t, env, 1*time.Minute, "normalize 1 record - first table", func() bool {
return s.comparePGTables(srcTable1Name, dstTable1Name, "id,t") == nil
})

// we have a paused mirror, wait for second signal to hit.
e2e.EnvWaitFor(s.t, env, 1*time.Minute, "sent updates signal", func() bool {
return sentUpdate
Expand All @@ -1287,9 +1280,8 @@ func (s PeerFlowE2ETestSuitePG) Test_Dynamic_Mirror_Config_Via_Signals() {
assert.Len(s.t, workflowState.SyncFlowOptions.SrcTableIdNameMapping, 2)
assert.Len(s.t, workflowState.SyncFlowOptions.TableNameSchemaMapping, 2)
// 3 from first insert of 18 rows in 1 table
// 1 from pre-pause
// 3 from second insert of 18 rows in 2 tables, batch size updated
assert.GreaterOrEqual(s.t, len(workflowState.SyncFlowStatuses), 3+1+3)
assert.GreaterOrEqual(s.t, len(workflowState.SyncFlowStatuses), 3+3)
env.CancelWorkflow()
}()

Expand Down
Loading