Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alerting): add email sender #1433

Merged
merged 23 commits into from
Mar 12, 2024
Merged

feat(alerting): add email sender #1433

merged 23 commits into from
Mar 12, 2024

Conversation

iamKunalGupta
Copy link
Member

@iamKunalGupta iamKunalGupta commented Mar 4, 2024 •
edited
Loading

New ENV Vars:

  • PEERDB_ALERTING_EMAIL_SENDER_SOURCE_EMAIL

  • PEERDB_ALERTING_EMAIL_SENDER_CONFIGURATION_SET

  • PEERDB_ALERTING_EMAIL_SENDER_REGION

  • PEERDB_ALERTING_EMAIL_SENDER_REPLY_TO_ADDRESSES

  • test aws cross region sending

    • config set is per region, have added env for setting a specific region

UI:
image

@iamKunalGupta iamKunalGupta force-pushed the feat/add-email-alert-sender-via-ses branch from 61bdc52 to 2971e54 Compare March 4, 2024 21:49
@iskakaushik iskakaushik requested a review from serprex March 4, 2024 21:50
@iamKunalGupta iamKunalGupta force-pushed the feat/add-email-alert-sender-via-ses branch from 6cafb4c to 8e14ad7 Compare March 8, 2024 21:24
@iamKunalGupta iamKunalGupta marked this pull request as ready for review March 8, 2024 21:25
@iamKunalGupta iamKunalGupta force-pushed the feat/add-email-alert-sender-via-ses branch from 8ee38cb to 471eea7 Compare March 11, 2024 19:27
@iamKunalGupta iamKunalGupta force-pushed the feat/add-email-alert-sender-via-ses branch from 7f24192 to 0b34a0b Compare March 12, 2024 15:51
@iamKunalGupta iamKunalGupta enabled auto-merge (squash) March 12, 2024 19:31
@iamKunalGupta iamKunalGupta merged commit d29f06d into main Mar 12, 2024
12 checks passed
@iamKunalGupta iamKunalGupta deleted the feat/add-email-alert-sender-via-ses branch March 12, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex left review comments

@Amogh-Bharadwaj Amogh-Bharadwaj Amogh-Bharadwaj approved these changes

@heavycrystal heavycrystal Awaiting requested review from heavycrystal

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamKunalGupta @serprex @Amogh-Bharadwaj