CDC Flow: fix state wipe #1434
Merged
CDC Flow: fix state wipe #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heavycrystal
approved these changes
Mar 5, 2024
|
@heavycrystal -- can you add a test that will prevent this from regressing? cc: @serprex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pause mirror second time onwards was not being respected as the state was not being wiped if only idle timeout / batch size is edited, because when additionTables is empty we just return nil before setting state to nil. This made flowConfigUpdate perenially not nil, which caused the mirror to never enter the pause loop.
This PR moves the setting of state to nil outside of processConfigUpdates and also adds logs