Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalize-done race causing sync/normalize to execute in parallel after pause/resume #1452

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Mar 8, 2024

Fixes #1448

Solves via two redundant angles:

  1. drain normalize-done at start
  2. don't send normalize-done when ctx.Err() != nil

The race was consistently happening when normalize received cancel while in normalize activity. It'd then send normalize-done to parent, who already having returned continue-as-new but waiting on children to finish, would have the signal buffer for its next run

@iskakaushik iskakaushik merged commit 120786f into main Mar 9, 2024
7 checks passed
@iskakaushik iskakaushik deleted the fix-normalize-done-race branch March 9, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential race causes sync/normalize parallelism
2 participants