Add environment variable to disable one-sync #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
approved these changes
Mar 15, 2024
serprex
force-pushed
the
env-disable-one-sync
branch
from
9a4100b to
8ef5c03
Compare
| @@ -51,6 +51,11 @@ func PeerDBCDCDiskSpillMemPercentThreshold() int { | |||
| return getEnvInt("PEERDB_CDC_DISK_SPILL_MEM_PERCENT_THRESHOLD", -1) | |||
| } | |||
|
|
|||
| // PEERDB_DISABLE_ONE_SYNC | |||
| func PeerDBDisableOneSync() bool { | |||
| return getEnvBool("PEERDB_DISABLE_ONE_SYNC", false) | |||
There was a problem hiding this comment.
nit: prefer it as enable and set true by default
There was a problem hiding this comment.
disabling it is going to be the rare setting so it makes sense to have that be the name
There was a problem hiding this comment.
kind of like disableTLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.