Simplify pgtype.Time to time.Time conversion #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
changed the title
|
Tests pass without limiting micros, but going to investigate this further & maybe add a test after I get #1491 merged |
auto-merge was automatically disabled
March 16, 2024 07:00
Pull request was converted to draft
pgtime is just microseconds, https://pkg.go.dev/github.com/jackc/pgtype#Time https://pkg.go.dev/time#UnixMicro
iskakaushik
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgtime is just microseconds,
https://pkg.go.dev/github.com/jackc/pgtype#Time
https://pkg.go.dev/time#UnixMicro