Move some environment variables to be fetched by catalog #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amogh-Bharadwaj
requested review from
iskakaushik and
serprex
and removed request for
iskakaushik
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Amogh-Bharadwaj
force-pushed
the
move-some-vars-to-dynamic
branch
from
bbd96aa to
b1b106f
Compare
serprex
reviewed
Mar 20, 2024
| return defaultValue | ||
| } | ||
|
|
||
| result, err := strconv.ParseInt(value.String, 10, 32) |
There was a problem hiding this comment.
Suggested change
| result, err := strconv.ParseInt(value.String, 10, 32) | |
| result, err := strconv.ParseInt(value.String, 10, 64) |
Should update signed code too
serprex
approved these changes
Mar 20, 2024
|
|
|
Outdated. Implemented by future PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, some configuration parameters for our mirrors are set via environment variables, while others are fetched from a table in catalog.
This PR:
alerting_settingstodynamic_settings