-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws): add credentials loading mechanism using sdk config #1507
Conversation
d7a7ca0
to
a7d2dc0
Compare
@iamKunalGupta can you file an issue to make an env param |
@iskakaushik this will lead to issues where s3 staging is supported but not required, like snowflake. It will add additional costs and overhead if enabled by default. |
@iamKunalGupta this could be useful for customers who wish to retain the raw streams of CDC for long periods of time, hence having the option would be nice. |
Important function is
GetAWSCredentialsProvider
inflow/connectors/utils/aws.go
Order (in descending preference):
PEERDB_<CONNECTOR-NAME>_AWS_CREDENTIALS_<AWS-ENV-NAME>
likePEERDB_CLICKHOUSE_AWS_CREDENTIALS_AWS_ACCESS_KEY_ID
Pending Items:
incompatible version check
compatible version check