Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SF storage integration fixes #1517

Merged
merged 2 commits into from
Mar 21, 2024
Merged

SF storage integration fixes #1517

merged 2 commits into from
Mar 21, 2024

Conversation

heavycrystal
Copy link
Contributor

Code is in need of general cleanup

  1. CDC was hardcoding to internal stage, make it respect external stages.
  2. fixing 1 leads to nil pointer dereference in CDC because integration detection accesses a field not set in CDC.

@iamKunalGupta iamKunalGupta linked an issue Mar 20, 2024 that may be closed by this pull request
cdc staging path for mirror with snowflake as destination is not honored #1516
Closed
@iskakaushik iskakaushik enabled auto-merge (squash) March 21, 2024 02:53
@iskakaushik iskakaushik merged commit 472d279 into main Mar 21, 2024
7 checks passed
@iskakaushik iskakaushik deleted the sf-s3-integration-patch branch March 21, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex approved these changes

@iamKunalGupta iamKunalGupta Awaiting requested review from iamKunalGupta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdc staging path for mirror with snowflake as destination is not honored
3 participants
@heavycrystal @serprex @iskakaushik